Implement account edit; add SessionHelper, PasswordHelper and ActionResult

src/Frontend/Accounts/AccountController.php

@@ -3,9 +3,11 @@ declare(strict_types=1);
 
 namespace MailAccountAdmin\Frontend\Accounts;
 
+use MailAccountAdmin\Common\ActionResult;
+use MailAccountAdmin\Common\SessionHelper;
 use MailAccountAdmin\Common\UserHelper;
+use MailAccountAdmin\Exceptions\InputValidationError;
 use MailAccountAdmin\Frontend\BaseController;
-use MailAccountAdmin\Models\Account;
 use MailAccountAdmin\Repositories\AccountRepository;
 use MailAccountAdmin\Repositories\AliasRepository;
 use Psr\Http\Message\ResponseInterface as Response;
@@ -14,14 +16,17 @@ use Slim\Views\Twig;
 
 class AccountController extends BaseController
 {
+    /** @var AccountHandler */
+    private $accountHandler;
     /** @var AccountRepository */
     private $accountRepository;
     /** @var AliasRepository */
     private $aliasRepository;
 
-    public function __construct(Twig $view, UserHelper $userHelper, AccountRepository $accountRepository, AliasRepository $aliasRepository)
+    public function __construct(Twig $view, SessionHelper $sessionHelper, UserHelper $userHelper, AccountHandler $accountHandler, AccountRepository $accountRepository, AliasRepository $aliasRepository)
     {
-        parent::__construct($view, $userHelper);
+        parent::__construct($view, $sessionHelper, $userHelper);
+        $this->accountHandler = $accountHandler;
         $this->accountRepository = $accountRepository;
         $this->aliasRepository = $aliasRepository;
     }
@@ -33,13 +38,9 @@ class AccountController extends BaseController
     {
         // Parse query parameters for filters
         $queryParams = $request->getQueryParams();
-        $filterByDomain = $queryParams['domain'] ?? null;
-
-        $renderData = [
-            'filterDomain' => $filterByDomain,
-            'accountList' => $this->accountRepository->fetchAccountList($filterByDomain),
-        ];
+        $filterByDomain = $queryParams['domain'] ?? '';
 
+        $renderData = $this->accountHandler->listAccounts($filterByDomain);
         return $this->view->render($response, 'accounts.html.twig', $renderData);
     }
 
@@ -51,28 +52,7 @@ class AccountController extends BaseController
         // Parse URL arguments
         $accountId = (int)$args['id'];
 
-        // Get account data from database
-        $account = $this->accountRepository->fetchAccountById($accountId);
-
-        // Don't display the password hash, but at least the type of hash (used hash algorithm)
-        if ($account->getPasswordHash() === '') {
-            $passwordHashType = 'empty';
-        } else {
-            $passwordHashInfo = password_get_info($account->getPasswordHash());
-            $passwordHashType = $passwordHashInfo['algoName'] ?? 'unknown';
-        }
-
-        // Get list of aliases for this account
-        $aliases = $this->aliasRepository->fetchAliasesForUserId($accountId);
-
-        $renderData = [
-            'id' => $accountId,
-            'accountUsername' => $account->getUsername(),
-            'account' => $account,
-            'passwordHashType' => $passwordHashType,
-            'aliases' => $aliases,
-        ];
-
+        $renderData = $this->accountHandler->getAccountDetails($accountId);
         return $this->view->render($response, 'account_details.html.twig', $renderData);
     }
 
@@ -81,6 +61,7 @@ class AccountController extends BaseController
 
     public function showAccountCreate(Request $request, Response $response): Response
     {
+        // TODO: just a placeholder
         return $this->showAccounts($request, $response);
     }
 
@@ -95,28 +76,52 @@ class AccountController extends BaseController
         // Get account data from database
         $account = $this->accountRepository->fetchAccountById($accountId);
 
-        // Render page
-        return $this->renderEditPage($response, $account);
-    }
-
-    public function editAccount(Request $request, Response $response, array $args): Response
-    {
-        // TODO: just a placeholder
-        $this->view->getEnvironment()->addGlobal('error', 'Not implemented yet!');
-        return $this->showAccountEdit($request, $response, $args);
-    }
-
-    private function renderEditPage(Response $response, Account $account, array $extraRenderData = []): Response
-    {
         $renderData = [
             'id' => $account->getId(),
             'accountUsername' => $account->getUsername(),
             'account' => $account,
         ];
 
-        return $this->view->render($response, 'account_edit.html.twig', array_merge($renderData, $extraRenderData));
+        $lastActionResult = $this->sessionHelper->getLastActionResult();
+        if ($lastActionResult !== null) {
+            $resultData = $lastActionResult->isSuccess()
+                ? ['success' => $lastActionResult->getMessage()]
+                : ['error' => $lastActionResult->getMessage()];
+            $resultData['editData'] = $lastActionResult->getInputData();
+            $renderData = array_merge($renderData, $resultData);
+        }
+
+        return $this->view->render($response, 'account_edit.html.twig', $renderData);
     }
 
+    public function editAccount(Request $request, Response $response, array $args): Response
+    {
+        // Parse URL arguments
+        $accountId = (int)$args['id'];
+
+        // Parse form data
+        $editData = $request->getParsedBody();
+        $errorMessage = null;
+
+        try {
+            // Validate input
+            $validatedEditData = AccountEditData::createFromArray($editData);
+            $this->accountHandler->editAccountData($accountId, $validatedEditData);
+        } catch (InputValidationError $e) {
+            $errorMessage = $e->getMessage();
+        }
+
+        if (empty($errorMessage)) {
+            $this->sessionHelper->setLastActionResult(ActionResult::createSuccessResult('Account data was saved.'));
+        } else {
+            $this->sessionHelper->setLastActionResult(ActionResult::createErrorResult($errorMessage, $editData));
+        }
+
+        // Redirect to edit form page via GET (PRG)
+        return $response->withHeader('Location', '/accounts/' . $accountId . '/edit')->withStatus(303);
+    }
+
+
     // -- /accounts/{id}/delete - Delete account
 
     public function showAccountDelete(Request $request, Response $response, array $args): Response